Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlserver] Merge high and low watermark data during snapshot reading process #2179

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

fuyun2024
Copy link
Contributor

fix this pr : #2178

@GOODBOY008 GOODBOY008 self-requested a review June 13, 2023 10:05
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuyun2024 I have left some comments.

public class RecordsFormatter {

private final DataType dataType;
private final ZoneId zoneId;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove useless field.

private TypeInformation<RowData> typeInfo;
private DebeziumDeserializationSchema<RowData> deserializationSchema;
private SimpleCollector collector;
private RowRowConverter rowRowConverter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add final to this fields.

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GOODBOY008 GOODBOY008 merged commit 66556ee into apache:master Jun 16, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants