-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sqlserver] Merge high and low watermark data during snapshot reading process #2179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fuyun2024 I have left some comments.
...server-cdc/src/main/java/com/ververica/cdc/connectors/sqlserver/source/offset/LsnOffset.java
Show resolved
Hide resolved
public class RecordsFormatter { | ||
|
||
private final DataType dataType; | ||
private final ZoneId zoneId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove useless field.
private TypeInformation<RowData> typeInfo; | ||
private DebeziumDeserializationSchema<RowData> deserializationSchema; | ||
private SimpleCollector collector; | ||
private RowRowConverter rowRowConverter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add final
to this fields.
f2f3973
to
efd5962
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix this pr : #2178