Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongodb] Add support for mongodb+srv connection protocol. #2203

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

Jiabao-Sun
Copy link
Contributor

Add support for mongodb+srv connection protocol.
Close #2049.

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jiabao-Sun Thanks for your contributions. I left a comment.

@@ -146,6 +146,13 @@ Connector Options
<td>String</td>
<td>Specify what connector to use, here should be <code>mongodb-cdc</code>.</td>
</tr>
<tr>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mongodb-cdc(ZH).md should be updated too.

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jiabao-Sun Jiabao-Sun merged commit d9ea355 into apache:master Jun 13, 2023
11 of 14 checks passed
spoon-lz pushed a commit to spoon-lz/flink-cdc-connectors that referenced this pull request Jun 13, 2023
@Jiabao-Sun Jiabao-Sun deleted the flink-cdc-2049 branch December 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for connection.string property in the MongoDB CDC Connector
2 participants