Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oracle] Correct the naming error #2405

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

e-mhui
Copy link
Contributor

@e-mhui e-mhui commented Aug 17, 2023

[oracle] Correct the naming error
Oracle reads the redo log instead of the binlog.

fix #2404

@ruanhang1993
Copy link
Contributor

@e-mhui There are some compile errors. Please rebase the master branch and fix the compile errors.

@e-mhui
Copy link
Contributor Author

e-mhui commented Aug 24, 2023

@e-mhui There are some compile errors. Please rebase the master branch and fix the compile errors.

Thanks, it has been fixed.

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e-mhui There are remain some in test.
1692890651562

@e-mhui
Copy link
Contributor Author

e-mhui commented Aug 25, 2023

@e-mhui There are remain some in test.
1692890651562

Thanks, it has been fixed.

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ruanhang1993 PTAL

@GOODBOY008 GOODBOY008 merged commit 8feb51b into apache:master Aug 26, 2023
13 of 15 checks passed
GOODBOY008 pushed a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
* [oracle] Correct the naming error

* Fix comments

* fix name error

(cherry picked from commit 8feb51b)
GOODBOY008 pushed a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
* [oracle] Correct the naming error

* Fix comments

* fix name error

(cherry picked from commit 8feb51b)
GOODBOY008 pushed a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
* [oracle] Correct the naming error

* Fix comments

* fix name error

(cherry picked from commit 8feb51b)
leonardBang pushed a commit that referenced this pull request Oct 31, 2023
* [oracle] Correct the naming error

* Fix comments

* fix name error

(cherry picked from commit 8feb51b)
zhongqishang pushed a commit to zhongqishang/flink-cdc that referenced this pull request Dec 7, 2023
* [oracle] Correct the naming error

* Fix comments

* fix name error

(cherry picked from commit 8feb51b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[oracle cdc] correct the naming error
3 participants