[postgres] close jdbc connection when close replication connection #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loserwang1024
added a commit
to loserwang1024/flink-cdc-connectors
that referenced
this pull request
Aug 23, 2023
loserwang1024
added a commit
to loserwang1024/flink-cdc-connectors
that referenced
this pull request
Aug 23, 2023
loserwang1024
force-pushed
the
fix-close-connection
branch
from
e85e388
to
6ec5705
Compare
loserwang1024
added a commit
to loserwang1024/flink-cdc-connectors
that referenced
this pull request
Aug 24, 2023
loserwang1024
force-pushed
the
fix-close-connection
branch
from
6ec5705
to
fd451f5
Compare
ruanhang1993
reviewed
Sep 7, 2023
...n/java/com/ververica/cdc/connectors/postgres/source/enumerator/PostgresSourceEnumerator.java
Outdated
Show resolved
Hide resolved
e-mhui
pushed a commit
to e-mhui/flink-cdc-connectors
that referenced
this pull request
Oct 18, 2023
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
…stream split (apache#2425) (cherry picked from commit 82e3053)
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
…stream split (apache#2425) (cherry picked from commit 82e3053)
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
…stream split (apache#2425) (cherry picked from commit 82e3053)
zhongqishang
pushed a commit
to zhongqishang/flink-cdc
that referenced
this pull request
Dec 7, 2023
…stream split (apache#2425) (cherry picked from commit 82e3053)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In PostgresSourceEnumerator#createSlotForGlobalStreamSplit, PostgresReplicationConnection will be closed after create slot.
However, not any PostgresReplicationConnection.close will close the PostgresConnection in messageDecoder, which is generated by Hikari pool and is passed to PostgresReplicationConnection.
See AbstractMessageDecoder.close:
Thus, the Hikari pool will be full if there is too much pg source.
Verified this problem
Debug PostgresReplicationConnection.close in any test.