[cdc-common] Introduce PIPELINE_LOCAL_TIME_ZONE which help handle time zone well #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanhang1993
reviewed
Dec 2, 2023
When we deal TIMESTAMP_LTZ type in Sink |
|
@lvyanquan @PatrickRen @Jiabao-Sun Would you like to help review this PR? |
lvyanquan
reviewed
Dec 3, 2023
flink-cdc-composer/src/main/java/com/ververica/cdc/composer/flink/FlinkPipelineComposer.java
Outdated
Show resolved
Hide resolved
leonardBang
force-pushed
the
sessiont_timezone_config
branch
from
50a4c99
to
942a8dc
Compare
lvyanquan
reviewed
Dec 3, 2023
flink-cdc-composer/src/main/java/com/ververica/cdc/composer/flink/FlinkPipelineComposer.java
Outdated
Show resolved
Hide resolved
leonardBang
force-pushed
the
sessiont_timezone_config
branch
from
942a8dc
to
be2deae
Compare
|
Thanks @PatrickRen and @lvyanquan for the insight, I've simplify the PR, appreciate if you can take a look |
lvyanquan
reviewed
Dec 3, 2023
flink-cdc-composer/src/main/java/com/ververica/cdc/composer/flink/FlinkPipelineComposer.java
Show resolved
Hide resolved
lvyanquan
reviewed
Dec 4, 2023
| context.getConfiguration().get(ValuesDataSinkOptions.PRINT_ENABLED)); | ||
| context.getPipelineConfiguration() | ||
| .get(ValuesDataSinkOptions.MATERIALIZED_IN_MEMORY), | ||
| context.getPipelineConfiguration().get(ValuesDataSinkOptions.PRINT_ENABLED)); |
There was a problem hiding this comment.
context.getFactoryConfiguration().
There was a problem hiding this comment.
And please fix the code style check failure. Thanks.
adress comments
leonardBang
changed the title
|
The failed tests is note related to this PR, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[cdc-common] Introduce PIPELINE_LOCAL_TIME_ZONE which help handle time zone well