Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0][cdc-runtime] Remove waitForFlushSuccess field in request handler #2812

Merged
merged 2 commits into from
Dec 5, 2023
Merged

[3.0][cdc-runtime] Remove waitForFlushSuccess field in request handler #2812

merged 2 commits into from
Dec 5, 2023

Conversation

ruanhang1993
Copy link
Contributor

@ruanhang1993 ruanhang1993 commented Dec 5, 2023 •
edited

Fix NullPointerException when the flush success happens before the release upstream request arrives.

@leonardBang
Copy link
Contributor

@ruanhang1993 Could you add description for this PR?

PatrickRen
PatrickRen approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruanhang1993 Thanks for the patch! LGTM.

@PatrickRen PatrickRen merged commit 30c8254 into apache:master Dec 5, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickRen PatrickRen PatrickRen approved these changes

Assignees
No one assigned
Labels
runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ruanhang1993 @leonardBang @PatrickRen