[bug][pipeline-connector][starrocks] Optimize char type mapping for starrocks pipeline connector #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WholeWorld-Timothy
changed the title
banmoy
reviewed
Dec 20, 2023
...ctor-starrocks/src/main/java/com/ververica/cdc/connectors/starrocks/sink/StarRocksUtils.java
Show resolved
Hide resolved
WholeWorld-Timothy
force-pushed
the
optimize-char-mapping
branch
3 times, most recently
from
70a8a00
to
df2c064
Compare
banmoy
reviewed
Dec 21, 2023
...ctor-starrocks/src/main/java/com/ververica/cdc/connectors/starrocks/sink/StarRocksUtils.java
Outdated
Show resolved
Hide resolved
...ctor-starrocks/src/main/java/com/ververica/cdc/connectors/starrocks/sink/StarRocksUtils.java
Show resolved
Hide resolved
...ocks/src/main/java/com/ververica/cdc/connectors/starrocks/sink/StarRocksMetadataApplier.java
Outdated
Show resolved
Hide resolved
WholeWorld-Timothy
force-pushed
the
optimize-char-mapping
branch
from
df2c064
to
533bbf3
Compare
Signed-off-by: 张田 <zhang_tian@inspur.com>
WholeWorld-Timothy
force-pushed
the
optimize-char-mapping
branch
from
533bbf3
to
a238d16
Compare
WholeWorld-Timothy
changed the title
WholeWorld-Timothy
changed the title
WholeWorld-Timothy
changed the title
|
LGTM. cc @lvyanquan PTAL |
Jiabao-Sun
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Thanks @WholeWorld-Timothy for this contribution.
Thanks @banmoy and @lvyanquan for the review.
+1
joyCurry30
pushed a commit
to joyCurry30/flink-cdc-connectors
that referenced
this pull request
Mar 22, 2024
…cks pipeline connector (apache#2895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the StarRocks, The primary key columns can be any of the following data types: BOOLEAN, TINYINT, SMALLINT, INT, BIGINT, LARGEINT, STRING, VARCHAR, DATE, and DATETIME, But it doesn't include CHAR.
When a char type appears in the primary key of MySQL, creating a table in StarRocks requires conversion to varchar type.