-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pipeline-connector][mysql] fix timestamp with timezone format #2952
Conversation
Thanks @whhe for this contribution. It makes sense. |
On which version will this bug be fixed? I will download one and test it out |
Sure, I will have a try to add a full types test case for it soon. For the issue cause, now the pipeline connector converts TIMESTAMP to TIMESTAMP_LTZ in MySqlTypeUtils.java#L194, while the original mysql source connector does not deal with TIMESTAMP WITH TIME ZONE, so it I think should only occur in e2e case. |
Thanks @whhe. Change it to |
Because MySqlValueConverters always uses UTC, so using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix ts with tz parser * test timestamp with default value * fix related test * use timestamp string in test cases (cherry picked from commit f3762a1)
…e#2952) * fix ts with tz parser * test timestamp with default value * fix related test * use timestamp string in test cases
Try to fix #2950