[cdc][e2e] Unify logic to clean docker image when connector e2e test finished #2978
Conversation
| @@ -174,6 +177,33 @@ public void after() { | |||
| mysqlInventoryDatabase.dropDatabase(); | |||
| } | |||
|
|
|||
| @AfterClass | |||
| public static void afterClass() { | |||
| // list all images and remove the ones that are not flink images and mysql image | |||
There was a problem hiding this comment.
Images with prefix testcontainers also need to be excluded.
There was a problem hiding this comment.
Fine, add the condition. The docker image of testcontainers just 12MB.
There was a problem hiding this comment.
I mean exclude it to keep it not be deleted here, or else I'm not sure if there will be any exception occurs as it should still be in use. By the way, should the filters be combined with || or &&?
|
|
|
emm，ob database container will not close after test. |
I'm not sure, maybe ClassRule is executed after AfterClass? If so we need to add After method to stop the ob container manually. |
|
@GOODBOY008 Maybe we can add @beforeClass for PostgresE2eITCase to start container. |
GOODBOY008
force-pushed
the
master-e2e-clean
branch
from
6d64059
to
aad2519
Compare
I think unify clean logic, just focus on final state. |
GOODBOY008
force-pushed
the
master-e2e-clean
branch
from
aad2519
to
69137fc
Compare
Unify logic to clean docker image when connector e2e test finished