Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Change old com.ververica dependency to flink #3110

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

xleoken
Copy link
Member

@xleoken xleoken commented Mar 6, 2024

Change old com.ververica dependency to flink. Follow up #3089

@lvyanquan
Copy link
Contributor

Hi @xleoken, Can you update flink-cdc.sh too?

@lvyanquan
Copy link
Contributor

@xleoken Hi,I‘ve merged one pr https://github.com/apache/flink-cdc/pull/3118/files and introduced one more package, can you rebase master and include it?

@xleoken
Copy link
Member Author

xleoken commented Mar 11, 2024

Make sense, updated.

Make sense, updated.

@xleoken
Copy link
Member Author

xleoken commented Mar 27, 2024

Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xleoken Thanks for the PR! LGTM.

@PatrickRen PatrickRen merged commit 5f4f86f into apache:master Mar 27, 2024
13 checks passed
@PatrickRen
Copy link
Contributor

@xleoken Could you open another PR to backport the patch to release-3.0 branch? Thanks

@xleoken
Copy link
Member Author

xleoken commented Mar 28, 2024

Thanks @PatrickRen.

Could you open another PR to backport the patch to release-3.0 branch? Thanks

We can not chang the pom.xml files in release-3.0 branch directly.

image

@PatrickRen
Copy link
Contributor

@xleoken Ah my mistake. We don't need to backport this one to release-3.0 as 3.1 will be the first version after the donation. Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment