-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34671][cdc] update README.md file to update links and description. #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LYanquan
force-pushed
the
FLINK-34671
branch
3 times, most recently
from
March 18, 2024 02:07
cff2403
to
33a575a
Compare
@leonardBang @PatrickRen PTAL. |
leonardBang
force-pushed
the
FLINK-34671
branch
from
March 18, 2024 12:42
8984112
to
4580de1
Compare
* 2fa/FLINK-34671: shell style style pic url YAML highlight suggestion suggestion [FLINK-34671][cdc] update README.md file to update links and description. [FLINK-34679][cdc][docs] Add core concept pages for Flink CDC docs [FLINK-34680][cdc][docs] Add overview page for CDC connectors and optimize connector docs [FLINK-34682][cdc][docs] Add "Understand Flink CDC API" page for Flink CDC docs [FLINK-34715][cdc][cdc-connector][mysql] Correctly close BinlogSplitReader in MySQL UTCase [FLINK-34684][cdc][docs] Add licenses page for Flink CDC docs [FLINK-34683][cdc][docs] Add contributing page for Flink CDC docs [FLINK-34678][cdc][docs] Add introduction page for Flink CDC docs # Conflicts: # README.md
leonardBang
force-pushed
the
FLINK-34671
branch
from
March 18, 2024 13:16
496a330
to
e16f477
Compare
* 2fa/FLINK-34671: suggestion # Conflicts: # README.md # docs/static/fig/flink-cdc-logo.png
leonardBang
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LYanquan for the contribution, I also push one commit to polish the description, LGTM now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some links of document should be updated after #3146 merged.Rebased to master.
See https://github.com/LYanquan/flink-cdc/tree/FLINK-34671 for a preview.