Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34685][cdc][doc] add kubernetes.md under deployment directory. #3165

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

lvyanquan
Copy link
Contributor

add kubernetes.md

@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 19, 2024
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvyanquan Thanks for the PR! I left some minor comments.

docs/content/docs/deployment/kubernetes.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/kubernetes.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/kubernetes.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/kubernetes.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/kubernetes.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/kubernetes.md Outdated Show resolved Hide resolved
@lvyanquan
Copy link
Contributor Author

Addressed it. @PatrickRen

Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvyanquan Thanks for the update! Overall LGTM except one dead link

docs/content/docs/deployment/kubernetes.md Outdated Show resolved Hide resolved
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvyanquan Thanks for the update! LGTM.

@PatrickRen PatrickRen merged commit 1fd0cfe into apache:master Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants