Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34724][docs] Fix broken web link in document of legacy Flink CDC Sources #3167

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 19, 2024
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loserwang1024 Thanks for the PR! I left a comment.


The dependencies are now available in your local `.m2` repository.

### Code Contribute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Developer Guide - Contribute to Flink CDC" should have covered how to contribute to Flink CDC, and it's also not appropriate for other sections like code style and doc contribution to be here.

Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loserwang1024 Thanks for the update! LGTM.

@PatrickRen PatrickRen merged commit 8098a9c into apache:master Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants