Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35251][cdc][runtime] Fix bug of serializing derivation mapping in SchemaDerivation #3267

Merged
merged 1 commit into from Apr 28, 2024

Conversation

PatrickRen
Copy link
Contributor

@PatrickRen PatrickRen commented Apr 27, 2024

This PR fixes bug of serializing derivation mapping in SchemaDerivation that mistakenly uses out.write instead of out.writeInt when serializing the size of the mapping, and also add a test case for validating serde of SchemaDerivation.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickRen for the fix, LGTM

@leonardBang leonardBang merged commit 9cc3451 into apache:master Apr 28, 2024
14 checks passed
PatrickRen added a commit that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants