-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[debezium] Fix JsonConverter Object NPE when program running on the c… #470
Conversation
5b157cb
to
22dfcff
Compare
|
||
private static final JsonConverter CONVERTER = new JsonConverter(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the root cause is JsonConverter
is not serializable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,can you have any good ways to solution this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply, you can defined private transient JsonConverter jsonConverter;
and then lazily initialize it
like
if (jsonConverter == null) {
// initialize it
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mincwang for the contribution, LGTM, could you also check the change works in cluster?
ok, I will fix it later along with code style |
…luster