support to read tables of inconsistent schema #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoyuxia
changed the title
luoyuxia
force-pushed
the
allow-schema-mismatch
branch
from
6591a34
to
e486a30
Compare
leonardBang
reviewed
Oct 11, 2021
Comment on lines
677
to
685
| new String[] { | ||
| "+I[111, user_111, Shanghai, 123567891234, user_111@foo.com]", | ||
| "+I[121, user_121, Shanghai, 123567891234, null]", | ||
| "+I[211, user_211, Shanghai, 123567891234, null]", | ||
| "+I[221, user_221, Shanghai, 123567891234, user_221@foo.com]", | ||
| "-U[111, user_111, Shanghai, 123567891234, user_111@foo.com]", | ||
| "+U[111, user_111, Shanghai, 123567891234, user_111@bar.org]", | ||
| "-U[211, user_211, Shanghai, 123567891234, null]", | ||
| "+U[211, user_211, HangZhou, 123567891234, null]", |
There was a problem hiding this comment.
We can order the records for better understanding, because we call assertEqualsInAnyOrder later
Comment on lines
692
to
698
| // should drop the userDatabase1 and userDatabase2 | ||
| for (UniqueDatabase database : new UniqueDatabase[]{userDatabase1, userDatabase2}) { | ||
| try (Connection connection = database.getJdbcConnection(); | ||
| Statement statement = connection.createStatement()) { | ||
| statement.execute("drop database " + database.getDatabaseName()); | ||
| } | ||
| } |
| name VARCHAR(255) NOT NULL DEFAULT 'flink', | ||
| address VARCHAR(1024), | ||
| phone_number VARCHAR(512), | ||
| email VARCHAR(255) |
There was a problem hiding this comment.
Could we use another field name which is different with the table in database1?
leonardBang
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.