-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[postgres] Support metadata columns for postgres-cdc connector #500
Conversation
Hi,@wuchong @leonardBang |
Thanks @GOODBOY008 for the nice work, I'll help review this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GOODBOY008 for the nice work, I only left several minor comments. And we should update the documentation when we introduce new feature. Appreciate if you can also update the documentation.
...cdc/src/test/java/com/ververica/cdc/connectors/postgres/table/PostgreSQLConnectorITCase.java
Outdated
Show resolved
Hide resolved
...dc/src/main/java/com/ververica/cdc/connectors/postgres/table/PostgreSQLReadableMetadata.java
Outdated
Show resolved
Hide resolved
...dc/src/test/java/com/ververica/cdc/connectors/postgres/table/PostgreSQLTableFactoryTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Leonard Xu <xbjtdcq@163.com>
…e is null. flink-cdc catch field value is default
Thanks @leonardBang code review for my pr. I have fixed all problems.By the way,mysql connector is updated too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GOODBOY008 for the great work, it's cool that you also update the mysql-cdc
documentation. LTGM once the CI green.
Expose following Postgres metadata columns in this PR:
issue: #249