Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[postgres] Support metadata columns for postgres-cdc connector #500

Merged
merged 3 commits into from
Nov 4, 2021

Conversation

GOODBOY008
Copy link
Member

Expose following Postgres metadata columns in this PR:

issue: #249

Key DataType Description
database_name STRING NOT NULL Name of the database that contain the row.
collection_name STRING NOT NULL Name of the collection that contain the row.
op_ts TIMESTAMP_LTZ(3) NOT NULL It indicates the time that the change was made in the database. If the record is read from snapshot of the table instead of the change stream, the value is always 0.

@GOODBOY008
Copy link
Member Author

GOODBOY008 commented Oct 14, 2021

Hi,@wuchong @leonardBang
If you are available, please help code review. Sorry for blocking meta data issue.Because of my incoming ACP exame.

@leonardBang
Copy link
Contributor

Thanks @GOODBOY008 for the nice work, I'll help review this one

@leonardBang leonardBang self-requested a review October 14, 2021 15:41
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GOODBOY008 for the nice work, I only left several minor comments. And we should update the documentation when we introduce new feature. Appreciate if you can also update the documentation.

GOODBOY008 and others added 2 commits November 3, 2021 11:31
Co-authored-by: Leonard Xu <xbjtdcq@163.com>
…e is null. flink-cdc catch field value is default
@GOODBOY008
Copy link
Member Author

GOODBOY008 commented Nov 3, 2021

Thanks @GOODBOY008 for the nice work, I only left several minor comments. And we should update the documentation when we introduce new feature. Appreciate if you can also update the documentation.

Thanks @leonardBang code review for my pr. I have fixed all problems.By the way,mysql connector is updated too.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GOODBOY008 for the great work, it's cool that you also update the mysql-cdc documentation. LTGM once the CI green.

@leonardBang leonardBang merged commit 0bd39e5 into apache:master Nov 4, 2021
@leonardBang leonardBang linked an issue Nov 4, 2021 that may be closed by this pull request
@GOODBOY008 GOODBOY008 deleted the postgre-metadata branch March 1, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Add mysql metadata column documentation
2 participants