Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Add necessary shaded dependencies #512

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

Jiabao-Sun
Copy link
Contributor

Add necessary shaded dependencies

@leonardBang
Copy link
Contributor

Thanks @Jiabao-Sun for the contribution, CC @lsyldliu

@lsyldliu
Copy link
Contributor

Thanks @Jiabao-Sun for the contribution, I left a minor comments

@lsyldliu
Copy link
Contributor

lsyldliu commented Oct 20, 2021

IMO, we just need include com.fasterxml.jackson.core:* in three module, the job can work well.

@Jiabao-Sun
Copy link
Contributor Author

IMO, we just need include com.fasterxml.jackson.core:* in three module, the job can work well.

com.fasterxml.jackson.datatype:jackson-datatype-jsr310 for JSR-310 Date and Time serialization.

com.google.guava:guava was dependent by

  • io.debezium.connector.mysql.GtidSet
  • io.debezium.util.ObjectSizeCalculator
  • io.debezium.connector.base.ChangeEventQueue

@Jiabao-Sun
Copy link
Contributor Author

In my opinion, extremely simplified dependencies are not a good practice.
It is difficult for us to cover all possible branches and predict the future changes.
The commonly used jars can be appropriately relaxed.

@lsyldliu
Copy link
Contributor

IMO, we just need include com.fasterxml.jackson.core:* in three module, the job can work well.

com.fasterxml.jackson.datatype:jackson-datatype-jsr310 for JSR-310 Date and Time serialization.

com.google.guava:guava was dependent by

  • io.debezium.connector.mysql.GtidSet
  • io.debezium.util.ObjectSizeCalculator
  • io.debezium.connector.base.ChangeEventQueue

Ok, tks

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiabao-Sun for the fix, LGTM, I'll figure out the reason for CI failure and then merge this one.

@leonardBang leonardBang merged commit fb63a96 into apache:master Oct 22, 2021
@Jiabao-Sun Jiabao-Sun deleted the fix-shaded-problem branch February 17, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants