Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] add docs for oracle cdc #515

Closed
wants to merge 4 commits into from

Conversation

luoyuxia
Copy link
Contributor

#418 introduces oracle cdc, so I add the documentation for it to make users can use it easily.

@luoyuxia
Copy link
Contributor Author

@mbalassi Hi, would you like to help review the documents for oracle-cdc?

@leonardBang
Copy link
Contributor

@luoyuxia Could you rebase master to address azure CI failure?

@leonardBang leonardBang mentioned this pull request Oct 22, 2021
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luoyuxia , I left some comments.

Dependencies
------------

In order to setup the Oracle CDC connector, the following table provides dependency information for both projects using a build automation tool (such as Maven or SBT) and SQl Client with SQL JAR bundles.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to setup the Oracle CDC connector, the following table provides dependency information for both projects using a build automation tool (such as Maven or SBT) and SQl Client with SQL JAR bundles.
In order to setup the Oracle CDC connector, the following table provides dependency information for both projects using a build automation tool (such as Maven or SBT) and SQL Client with SQL JAR bundles.


### Maven dependency

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```xml


### SQL Client JAR

```Download link is available only for stable releases.```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```Download link is available only for stable releases.```
**Download link is available only for stable releases.**


1. Enable log archiving

a. Connect to the database as DBA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a. Connect to the database as DBA
(1.1) Connect to the database as DBA

Change a to format (1.1)?

The Oracle CDC table can be defined as following:

```sql
-- register an Oracle table 'orders' in Flink SQL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

products?

'schema-name' = 'inventory',
'table-name' = 'products');

-- read snapshot and binlogs from orders table
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

products?

name STRING,
description STRING,
weight DECIMAL(10, 3),
PRIMARY KEY(order_id) NOT ENFORCED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id?

wuchong pushed a commit that referenced this pull request Oct 26, 2021
@leonardBang
Copy link
Contributor

Implemented in c861418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants