validate the regex pattern of database-name and table-name in table f… #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuchong
reviewed
Oct 27, 2021
| Map<String, String> properties = getAllOptions(); | ||
| properties.put("table-name", "*_invalid_table"); | ||
| } catch (Throwable t) { | ||
| String msg = String.format("The table-name is invalid: '%s'", "*_invalid_table"); |
There was a problem hiding this comment.
We don't need String.format here because the string is deterministic.
| @@ -231,4 +234,22 @@ private void validateFetchSize(int fetchSize) { | |||
| "The value of option '%s' must larger than 1, but is %d", | |||
| SCAN_SNAPSHOT_FETCH_SIZE.key(), fetchSize)); | |||
| } | |||
|
|
|||
| private void validateDatabaseName(String databaseName) { | |||
There was a problem hiding this comment.
validateDatabaseName and validateTableName can share a same method, e.g.
/**
* Checks the given regular expression's syntax is valid.
*
* @param optionName the option name of the regex
* @param regex The regular expression to be checked
* @throws ValidationException If the expression's syntax is invalid
*/
private void validateRegex(String optionName, String regex) {
try {
Pattern.compile(regex);
} catch (Exception e) {
throw new ValidationException(
String.format(
"The %s '%s' is not a valid regular expression", optionName, regex),
e);
}
}
luoyuxia
force-pushed
the
validate-regex-pattern
branch
from
b4afba3
to
a822c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…actory #491
Add validation check for the regex pattern of database-name and table-name in table factory to avoid exception during runtime