[mysql] polish binlog offset compare semantic #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwpku
changed the title
leonardBang
reviewed
Nov 1, 2021
...r-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/offset/BinlogOffset.java
Show resolved
Hide resolved
added 2 commits
November 2, 2021 18:35
the `isAtOrBefore & isBefore` was actually meaning `isAtOrAfter & isAfter`, so let's do this right ;) Signed-off-by: Zhao Junwang <zhjwpku@gmail.com>
1. HighWatermark itself should not be emitted 2. If the highWatermark equals maxHighWatermark, tableIdBinlogPositionMap doesn't need to change 3. change `compareTo < 0` to the more understandable isBefore Signed-off-by: Zhao Junwang <zhjwpku@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
isAtOrBefore & isBeforewas actually meaningisAtOrAfter & isAfter, so let's do this right ;)Signed-off-by: Zhao Junwang zhjwpku@gmail.com