[oracle] Fix Numeric type #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashulin
force-pushed
the
fix-oracle-numeric
branch
from
3dc58c6
to
cc5d897
Compare
|
I'm glad to review. |
|
Thanks @ashulin for the contribution. Could you describe what bug you want to fix? And could you also add a test which can reproduce the bug? |
ashulin
force-pushed
the
fix-oracle-numeric
branch
from
cc5d897
to
66c498e
Compare
|
@luoyuxia Please take a look. |
ashulin
changed the title
This was referenced Dec 2, 2021
Closed
|
@leonardBang Please take a look. |
leonardBang
reviewed
Dec 16, 2021
...in/java/com/ververica/cdc/connectors/oracle/table/OracleDeserializationConverterFactory.java
Show resolved
Hide resolved
...racle-cdc/src/test/java/com/ververica/cdc/connectors/oracle/table/OracleConnectorITCase.java
Outdated
Show resolved
Hide resolved
leonardBang
approved these changes
Jan 5, 2022
|
The failed MongoDB test is not related to this PR， merging... |
YesOrNo828
pushed a commit
to YesOrNo828/flink-cdc-connectors
that referenced
this pull request
Jan 12, 2022
rookie202010
pushed a commit
to rookie202010/flink-cdc-connectors
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the field type of oracle table is NUMBER or FLOAT type, it is processed as
io.debezium.data.VariableScaleDecimalin debezium. In this case, the mapping will throw an exception for flink's INT/FLOAT and other numeric types.