[hotfix][mongodb] Fix problem of cannot look up fields on non-struct type #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiabao-Sun
changed the title
Jiabao-Sun
force-pushed
the
fix-npe-when-heartbeat-enabled-p2
branch
from
9f5c472
to
e85e537
Compare
Jiabao-Sun
force-pushed
the
fix-npe-when-heartbeat-enabled-p2
branch
from
e85e537
to
5909620
Compare
|
@leonardBang, If you are available, please help review it. |
wuchong
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Thanks @Jiabao-Sun for the fixing. I also encountered this problem when adding mongodb e2e tests. And this PR does fix the problem. However, it would be better to add a test in the PR which can reproduce the problem when fixing a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem of cannot look up fields on non-struct type