[docs] Changed field names to uppercase in Flink create table SQL. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardBang
reviewed
Nov 18, 2021
Comment on lines
288
to
-291
| schema_name STRING METADATA FROM 'schema_name' VIRTUAL, | ||
| table_name STRING METADATA FROM 'table_name' VIRTUAL, | ||
| operation_ts TIMESTAMP_LTZ(3) METADATA FROM 'op_ts' VIRTUAL, | ||
| id INT NOT NULL, |
There was a problem hiding this comment.
The metadata column name accepts both lowercase and uppercase, could we add a note for physical column that The original oralce column name is uppercase by default.
There was a problem hiding this comment.
Thanks @leonardBang , I will do it.
paul8263
force-pushed
the
oracle-cdc-doc-sql
branch
from
c8a2142
to
325cd5a
Compare
leonardBang
reviewed
Nov 18, 2021
paul8263
force-pushed
the
oracle-cdc-doc-sql
branch
from
7fd3c5d
to
1e50a70
Compare
|
@paul8263 Could you also open a PR for release-2.1 branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Oracle database if we created a table without quoting the field names, it would automatically convert the field names to uppercase. As a result, we can get the right data only if we create table in Flink with field names excatly matching cases with those defined in Oracle. Field name defined without quotes will be convert to uppercase by oracle and fieled names in SQL executed in Oracle will also be converted to uppercase. However, Flink SQL will not do it, which means usually we have to create table with uppercased field names, otherwise we would get null values.
To minify the misleading effect of the document, I suggest we change the field names in oracle-cdc.md to uppercase. By the way we can keep it consistent with those SQLs in oracle-tutorial-zh.md.