Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mysql] add an interface to get MySqlSourceConfigFactory #648

Merged
merged 1 commit into from Nov 30, 2021
Merged

[mysql] add an interface to get MySqlSourceConfigFactory #648

merged 1 commit into from Nov 30, 2021

Conversation

zhjwpku
Copy link
Contributor

@zhjwpku zhjwpku commented Nov 24, 2021

Expose an interface for user to use the MySqlSourceConfigFactory#createConfig.

Some discussion can be found here [0]

[0] #638

Signed-off-by: 元组 zhaojunwang.zjw@alibaba-inc.com

Expose an interface for user to use the MySqlSourceConfigFactory#createConfig.

Some discussion can be found here [0]

[0]: #638

Signed-off-by: 元组 <zhaojunwang.zjw@alibaba-inc.com>
@zhjwpku
Copy link
Contributor Author

zhjwpku commented Nov 30, 2021

Hi @wuchong, this PR is opened based on the discussion from #638 , can you please help to review this?

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 56112e9 into apache:master Nov 30, 2021
rookie202010 pushed a commit to rookie202010/flink-cdc-connectors that referenced this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants