Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Common] The abstraction of Incremental Snapshot Framework #776

Merged
merged 3 commits into from
Mar 27, 2022

Conversation

YesOrNo828
Copy link
Contributor

Add a new module(flink-connector-base) which contain the common abstraction of incremental snapshot framework. So other db connectors could implement the Incremental Snapshot algorithm more easier. #724

@leonardBang leonardBang self-requested a review January 6, 2022 06:04
@YesOrNo828 YesOrNo828 changed the title [Common] The abstraction of Incremental Snapshot Framework [WIP][Common] The abstraction of Incremental Snapshot Framework Jan 7, 2022
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YesOrNo828 for the awesome work , I think we're in right way.
I left several comments, and I think we can introduce a moudlue/connector like mysql-connecor-cdc-new which depends on our new framework, this won't influence current connector and help to validate our design in POC.
BTW, we can rebase master where I fix a log issue that prevent we look LOG in IDE.

@YesOrNo828
Copy link
Contributor Author

@leonardBang Thanks for you reviewing.
I have rebased my branch.
And adding new module to validate the new framework that idea is good to me. I will do more test work.

@leonardBang leonardBang force-pushed the issue-724 branch 2 times, most recently from ea480fb to e9a4851 Compare March 8, 2022 04:13
@leonardBang
Copy link
Contributor

@YesOrNo828 @GOODBOY008 I help fix the code style and conflicts, we can review&develop base on current code base.

@yangrong688
Copy link

Hi @YesOrNo828, @leonardBang , does this feature can apply to postgres-cdc when it complete.

@leonardBang
Copy link
Contributor

Thanks @YesOrNo828 for the great work, I make some improvement base on your work, I think it's ok to merge now as the first version of framework.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leonardBang leonardBang merged commit 2b71309 into apache:master Mar 27, 2022
@1032851561
Copy link

Hi @YesOrNo828, @leonardBang , does this feature can apply to postgres-cdc when it complete.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants