-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][Common] The abstraction of Incremental Snapshot Framework #776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @YesOrNo828 for the awesome work , I think we're in right way.
I left several comments, and I think we can introduce a moudlue/connector like mysql-connecor-cdc-new
which depends on our new framework, this won't influence current connector and help to validate our design in POC.
BTW, we can rebase master where I fix a log issue that prevent we look LOG in IDE.
...k-connector-base/src/main/java/com/ververica/cdc/connectors/base/source/dialect/Dialect.java
Outdated
Show resolved
Hide resolved
...k-connector-base/src/main/java/com/ververica/cdc/connectors/base/source/dialect/Dialect.java
Outdated
Show resolved
Hide resolved
...ase/src/main/java/com/ververica/cdc/connectors/base/source/dialect/SnapshotEventDialect.java
Outdated
Show resolved
Hide resolved
@leonardBang Thanks for you reviewing. |
0c37761
to
05f64a1
Compare
...ql-cdc-new/src/main/java/com/ververica/cdc/connectors/mysql/refactor/schema/MySqlSchema.java
Outdated
Show resolved
Hide resolved
ea480fb
to
e9a4851
Compare
@YesOrNo828 @GOODBOY008 I help fix the code style and conflicts, we can review&develop base on current code base. |
Hi @YesOrNo828, @leonardBang , does this feature can apply to postgres-cdc when it complete. |
Thanks @YesOrNo828 for the great work, I make some improvement base on your work, I think it's ok to merge now as the first version of framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
+1 |
Add a new module(flink-connector-base) which contain the common abstraction of incremental snapshot framework. So other db connectors could implement the Incremental Snapshot algorithm more easier. #724