Fix the type information of source funtion and add tests #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leonardBang Please code review. |
|
@luoyuxia Please code review. |
leonardBang
reviewed
Feb 18, 2022
There was a problem hiding this comment.
Thanks @ashulin for the contribution, I left some comments about the assertSourceFunction, other parts looks good to me.
flink-connector-test-util/src/main/java/com/ververica/cdc/connectors/utils/AssertUtils.java
Outdated
Show resolved
Hide resolved
leonardBang
force-pushed
the
fix-metadata-produced-data-type
branch
from
0ace14a
to
a2dc8bf
Compare
|
@ashulin Thanks for the contribution, I help rebase and update the tests, will merge once the ci passed ^_^ |
leonardBang
approved these changes
Mar 9, 2022
|
The failed test is not related to current PR, I've create an issue #919 to track it. merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the test, I found that the typeInfo created by the OracleTableSource was incorrect, because the producedDataType processed by #applyReadableMetadata was not used.
I added a test method to ensure that the data type of the source funtion matches the expected schema data type.