Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][mysql] add connection options #857

Merged
merged 1 commit into from
Feb 15, 2022
Merged

[docs][mysql] add connection options #857

merged 1 commit into from
Feb 15, 2022

Conversation

teckick
Copy link
Contributor

@teckick teckick commented Feb 14, 2022 •
edited

This PR fixes issue #854.

add connection options in mysql connectors docs:

  • connection.pool.size
  • connect.max-retries

@teckick teckick changed the title docs: add connection options in mysql connectors [docs][mysql] add connection options #854 Feb 14, 2022
@teckick teckick changed the title [docs][mysql] add connection options #854 [docs][mysql] add connection options Feb 14, 2022
@teckick teckick mentioned this pull request Feb 15, 2022
Closed
@leonardBang leonardBang linked an issue Feb 15, 2022 that may be closed by this pull request
[doc] Add connection.pool.size and connect.max-retries option in mysql document #854
Closed
@leonardBang leonardBang self-requested a review February 15, 2022 02:43
leonardBang
leonardBang approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @eastfisher, LGTM.

@leonardBang leonardBang merged commit 77e9b44 into apache:master Feb 15, 2022
@leonardBang
Copy link
Contributor

@eastfisher Could you also open a PR for release-2.1 branch?

@teckick teckick mentioned this pull request Feb 15, 2022
Merged
@teckick
Copy link
Contributor Author

teckick commented Feb 15, 2022

@eastfisher Could you also open a PR for release-2.1 branch?

Open a new PR.

#858

BTW, is there a bot to do this, like cherry-bot?

@leonardBang
Copy link
Contributor

leonardBang commented Feb 15, 2022 •
edited

BTW, is there a bot to do this, like cherry-bot?

Cool! I don't know this robot yet, would you like add a robot for our project? but looks like this need some efforts.

@teckick teckick deleted the docs-update-mysql-connectors branch February 15, 2022 05:48
@teckick
Copy link
Contributor Author

teckick commented Feb 15, 2022

BTW, is there a bot to do this, like cherry-bot?

Cool! I don't know this robot yet, would you like add a robot for our project? but looks like this need some efforts.

Issue is created: #859, but I'm afraid have no enough time to finish it.

@leonardBang
Copy link
Contributor

Issue is created: #859, but I'm afraid have no enough time to finish it.

Don't worry, it's good enough fine we've recorded this idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardBang leonardBang leonardBang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc] Add connection.pool.size and connect.max-retries option in mysql document
2 participants
@teckick @leonardBang