Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common] DebeziumChangeFetcher's emit delay and fetch delay should be unavailable during the snapshot phase #878

Merged
merged 1 commit into from
Feb 22, 2022
Merged

[common] DebeziumChangeFetcher's emit delay and fetch delay should be unavailable during the snapshot phase #878

merged 1 commit into from
Feb 22, 2022

Conversation

fsk119
Copy link
Member

@fsk119 fsk119 commented Feb 22, 2022

Solve #868 .

leonardBang
leonardBang approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonardBang leonardBang linked an issue Feb 22, 2022 that may be closed by this pull request
[common][bug] The 'ts_ms' field in snapshot SourceRecord returns non zero milliseconds #868
Closed
@leonardBang leonardBang merged commit fc5538b into apache:master Feb 22, 2022
@fsk119 fsk119 deleted the fix-metric branch February 22, 2022 02:45
fangpengcheng95 pushed a commit to fangpengcheng95/flink-cdc-connectors that referenced this pull request Feb 23, 2022
@fsk119 @fangpengcheng95
[common] Fix emitDelay and fetchDelay metrics to be 0L during snapsho…
c01122e 
…t phase (apache#878)
fangpengcheng95 added a commit to fangpengcheng95/flink-cdc-connectors that referenced this pull request Feb 23, 2022
@fangpengcheng95
Revert "[common] Fix emitDelay and fetchDelay metrics to be 0L during…
eb1562c 
… snapshot phase (apache#878)"

This reverts commit c01122e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardBang leonardBang leonardBang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[common][bug] The 'ts_ms' field in snapshot SourceRecord returns non zero milliseconds
2 participants
@fsk119 @leonardBang