[mongodb] Plan2: Match multiple database and collection names using a regular expression in MongoDB. #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiabao-Sun
force-pushed
the
mongodb-namespace-filter-plan2
branch
2 times, most recently
from
7d7b93a
to
f9a9a84
Compare
Jiabao-Sun
force-pushed
the
mongodb-namespace-filter-plan2
branch
from
f9a9a84
to
b6429e0
Compare
leonardBang
reviewed
Mar 14, 2022
| @@ -226,4 +256,103 @@ private boolean isCopying() { | |||
| throw new IllegalStateException("Cannot access isCopying field of SourceTask", e); | |||
| } | |||
| } | |||
|
|
|||
| private void init(Map<String, String> props) { | |||
There was a problem hiding this comment.
Suggested change
| private void init(Map<String, String> props) { | |
| private void initCapturedCollections(MongoClient mongoClient, Map<String, String> props) { |
and then we can put this method to CollectionDiscoveryUtils
|
|
||
| /** match single database and multiple collections: collection = ^db0\.coll_b\d?$ . */ | ||
| @Test | ||
| public void testMatchSingleDatabaseAndMultipleCollections() throws Exception { |
There was a problem hiding this comment.
Suggested change
| public void testMatchSingleDatabaseAndMultipleCollections() throws Exception { | |
| public void testMatchSingleQualifiedCollectionPattern() throws Exception { |
|
|
||
| /** match single database and multiple collections: database = db0 collection = .*coll_b\d? . */ | ||
| @Test | ||
| public void testMatchSingleDatabaseAndMultipleCollections1() throws Exception { |
There was a problem hiding this comment.
Suggested change
| public void testMatchSingleDatabaseAndMultipleCollections1() throws Exception { | |
| public void testMatchSingleDatabaseWithCollectionPattern() throws Exception { |
Comment on lines
321
to
337
| ### MongoDB Namespaces Filters | ||
|
|
||
| The config option `copy.existing.namespace.regex` is a regular expression that matches the namespaces from which to copy data.<br> | ||
|
|
||
| In the following example, matches namespaces `db0.coll0` and `db1.coll1` to snapshot. | ||
|
|
||
| ``` | ||
| 'copy.existing.namespace.regex' = '^(db0\\.coll0|db1\\.coll1)$' | ||
| ``` | ||
|
|
||
| The config option `namespace.regex` is a regular expression that matches the namespaces from which to watch for changes.<br> | ||
|
|
||
| In the following example, matches namespaces `db0.coll0` and `db1.coll1` to watch. | ||
|
|
||
| ``` | ||
| 'namespace.regex' = '^(db0\\.coll0|db1\\.coll1)$' | ||
| ``` |
There was a problem hiding this comment.
Do we still need this document?
There was a problem hiding this comment.
Thanks, I missed it here.
Jiabao-Sun
force-pushed
the
mongodb-namespace-filter-plan2
branch
from
603f474
to
c851129
Compare
leonardBang
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Thanks @Jiabao-Sun for the update, LGTM.
Please feel free to merge once the CI passed.
|
Thanks @leonardBang , @bobby-richard. |
This was referenced Mar 15, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match multiple database and collection names using a regular expression in MongoDB.
Support regex filter by databaseList and collectionList.