Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29688] Add test to detect changes in DynamoDB model #22

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

dannycranmer
Copy link
Contributor

What is the purpose of the change

Add test to detect changes in DynamoDB model

Brief change log

  • Add test to detect changes in DynamoDB model

Verifying this change

Tests pass

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? n/a

Copy link
Contributor

@hlteoh37 hlteoh37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just wonder if we should be a little tighter on the contract (e.g. field types). However, approving, since it is more likely that when contract changes, fields are added, rather than modified (for backwards compatibility)

@dannycranmer dannycranmer merged commit 4427bcd into apache:main Nov 14, 2022
@dannycranmer dannycranmer deleted the FLINK-29688 branch November 14, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants