Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30098] Migrate DynamoDb unit tests to JUnit5 #23

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

hlteoh37
Copy link
Contributor

What is the purpose of the change

Migrate DynamoDb unit tests to JUnit5

Verifying this change

Ran unit tests locally and verified all passed.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? n/a

@YuriGusev
Copy link
Contributor

Thanks for fixing. I thought I changed these tests. Probably got lost during rebase/merges.

Copy link
Contributor

@dannycranmer dannycranmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hlteoh37, LGTM

@dannycranmer dannycranmer merged commit 53ea410 into apache:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants