Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml #73

Merged
merged 1 commit into from
May 15, 2023
Merged

[FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml #73

merged 1 commit into from
May 15, 2023

Conversation

reswqa
Copy link
Member

@reswqa reswqa commented May 11, 2023 •
edited

Purpose of the change

Short code related to externalized connector retrieve version from its own data yaml.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Significant changes

  • Dependencies have been added or upgraded
  • Public API has been changed (Public API is any class annotated with @Public(Evolving))
  • Serializers have been changed
  • New feature has been introduced
    • If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)

dannycranmer
dannycranmer approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@dannycranmer dannycranmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @reswqa

@reswqa
Copy link
Member Author

reswqa commented May 12, 2023 •
edited

Thanks for the review! I will merge this after FLINK-32024 in apache/flink merged.

@reswqa reswqa merged commit 4ec9d4f into apache:main May 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannycranmer dannycranmer dannycranmer approved these changes

Assignees
No one assigned
Labels
component=Documentation
Projects
None yet
Milestone
No milestone
2 participants
@reswqa @dannycranmer