[FLINK-35135][Connectors/Google Cloud PubSub] Drop support for Flink 1.17 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycranmer
force-pushed
the
FLINK-35135
branch
from
88842d4
to
fce2a0c
Compare
hlteoh37
reviewed
Apr 17, 2024
| @@ -28,11 +28,9 @@ jobs: | |||
| compile_and_test: | |||
| strategy: | |||
| matrix: | |||
| flink: [ 1.17-SNAPSHOT ] | |||
| jdk: [ '8, 11' ] | |||
| flink: [ 1.18-SNAPSHOT ] | |||
There was a problem hiding this comment.
curious why we don't use the real 1.18 (instead of 1.18-SNAPSHOT) for pr
There was a problem hiding this comment.
I am not sure, I agree that makes sense though.
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop 1.17 runs from CI and bump default Flink version in pom