Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-35322][Connectors/Google PubSub] Remove weekly tests of 1.19 for unsupporting version v3.0 #26

Merged
merged 1 commit into from
May 12, 2024
Merged

[FLINK-35322][Connectors/Google PubSub] Remove weekly tests of 1.19 for unsupporting version v3.0 #26

merged 1 commit into from
May 12, 2024

Conversation

vahmed-hamdy
Copy link
Contributor

@vahmed-hamdy vahmed-hamdy commented May 10, 2024 •
edited

Description

  • Weekly builds are failing due to tests against Flink 1.19 using version 3.0 which is incompatible.
  • We should only add stable release tests on 3.1 once released

Changelog

  • Remove weekly tests for 1.19 using v3.0, leaving only main branch.

Testing

@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented May 10, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@vahmed-hamdy
Copy link
Contributor Author

@snuyanzin Could you please take a look?

@snuyanzin
Copy link
Contributor

@vahmed-hamdy thanks for the contribution
could you please schedule a weekly job on your fork to be sure it passes and put a link here?

@vahmed-hamdy
Copy link
Contributor Author

@snuyanzin yes, I added the rub link to the PR description for the same commit changes.

snuyanzin
snuyanzin approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks

@snuyanzin snuyanzin merged commit 725f3d6 into apache:main May 12, 2024
12 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented May 12, 2024

Awesome work, congrats on your first merged pull request!

@vahmed-hamdy vahmed-hamdy deleted the flink--35322-weekly-build-fix branch May 13, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snuyanzin snuyanzin snuyanzin approved these changes

Assignees
No one assigned
Labels
component=BuildSystem
Projects
None yet
Milestone
No milestone
2 participants
@vahmed-hamdy @snuyanzin