[FLINK-35548] Add E2E tests for PubSubSinkV2 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snuyanzin Could you please have a look at this much smaller PR? |
morazow
suggested changes
Jun 7, 2024
...-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java
Outdated
Show resolved
Hide resolved
...-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java
Outdated
Show resolved
Hide resolved
...ub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/util/PubsubHelper.java
Outdated
Show resolved
Hide resolved
vahmed-hamdy
force-pushed
the
gcp-pubsub-sink-e2e
branch
2 times, most recently
from
9a374f2
to
1e45ee3
Compare
morazow
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Hi @vahmed-hamdy thanks for driving this PR.
I left a few comments, PTAL. Also,I think we need IT tests for failing scenarios (e.g. for when error shutting down topic client, admin client, channel, etc). WDYT?
...-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java
Outdated
Show resolved
Hide resolved
...-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java
Show resolved
Hide resolved
...-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java
Outdated
Show resolved
Hide resolved
...ub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/util/PubsubHelper.java
Show resolved
Hide resolved
...ub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/util/PubsubHelper.java
Show resolved
Hide resolved
...ub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/util/PubsubHelper.java
Outdated
Show resolved
Hide resolved
vahmed-hamdy
force-pushed
the
gcp-pubsub-sink-e2e
branch
from
1e45ee3
to
f96ed11
Compare
snuyanzin
reviewed
Jun 9, 2024
...-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java
Outdated
Show resolved
Hide resolved
snuyanzin
reviewed
Jun 9, 2024
...-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java
Outdated
Show resolved
Hide resolved
snuyanzin
reviewed
Jun 9, 2024
...-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java
Outdated
Show resolved
Hide resolved
snuyanzin
reviewed
Jun 9, 2024
...a/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/EmulatorCredentialsProvider.java
Show resolved
Hide resolved
vahmed-hamdy
force-pushed
the
gcp-pubsub-sink-e2e
branch
from
f96ed11
to
dbe1cdd
Compare
|
@jeyhunkarimov thanks for the feedback, I added a negative test as well |
|
Thanks for addressing feedback |
vahmed-hamdy
force-pushed
the
gcp-pubsub-sink-e2e
branch
from
dbe1cdd
to
5490616
Compare
|
@snuyanzin All addressed now ✅ |
snuyanzin
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Thanks for addressing feedback and thanks for contribution @vahmed-hamdy
thanks for the review @jeyhunkarimov , @morazow
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add E2E tests for
PubsubSinkV2Verification