[FLINK-30062][Connectors/HBase] ADDENDUM: Bundle the exact same dependencies as it was in core

[ferenc-csaky]

Without this, we not package the HBase specific classes into the flink-sql-connector-hbase-2.2 artifact.

[zentol]

It's still a bit different than what was bundled in 1.16.0.
1.16.0:

[INFO] Including org.apache.flink:flink-connector-hbase-2.2:jar:1.16.0 in the shaded jar.
[INFO] Including org.apache.flink:flink-connector-hbase-base:jar:1.16.0 in the shaded jar.
[INFO] Including org.apache.hbase:hbase-client:jar:2.2.3 in the shaded jar.
[INFO] Including org.apache.hbase.thirdparty:hbase-shaded-protobuf:jar:2.2.1 in the shaded jar.
[INFO] Including org.apache.hbase:hbase-common:jar:2.2.3 in the shaded jar.
[INFO] Including org.apache.hbase:hbase-protocol-shaded:jar:2.2.3 in the shaded jar.
[INFO] Including org.apache.hbase:hbase-protocol:jar:2.2.3 in the shaded jar.
[INFO] Including commons-codec:commons-codec:jar:1.15 in the shaded jar.
[INFO] Including org.apache.commons:commons-lang3:jar:3.3.2 in the shaded jar.
[INFO] Including org.apache.hbase.thirdparty:hbase-shaded-miscellaneous:jar:2.2.1 in the shaded jar.
[INFO] Including com.google.protobuf:protobuf-java:jar:2.5.0 in the shaded jar.
[INFO] Including org.apache.hbase.thirdparty:hbase-shaded-netty:jar:2.2.1 in the shaded jar.
[INFO] Including org.apache.zookeeper:zookeeper:jar:3.4.14 in the shaded jar.
[INFO] Including org.apache.htrace:htrace-core4:jar:4.2.0-incubating in the shaded jar.
[INFO] Including io.dropwizard.metrics:metrics-core:jar:3.2.6 in the shaded jar.
[INFO] Including org.apache.commons:commons-crypto:jar:1.0.0 in the shaded jar.
[INFO] Including io.netty:netty-all:jar:4.1.70.Final in the shaded jar.

PR:

[INFO] Including org.apache.flink:flink-connector-hbase-2.2:jar:1.0-SNAPSHOT in the shaded jar.
[INFO] Including org.apache.flink:flink-connector-hbase-base:jar:1.0-SNAPSHOT in the shaded jar.
[INFO] Including org.apache.hbase:hbase-client:jar:2.2.3 in the shaded jar.
[INFO] Including org.apache.hbase.thirdparty:hbase-shaded-protobuf:jar:2.2.1 in the shaded jar.
[INFO] Including org.apache.hbase:hbase-common:jar:2.2.3 in the shaded jar.
[INFO] Including org.apache.hbase:hbase-protocol-shaded:jar:2.2.3 in the shaded jar.
[INFO] Including org.apache.hbase:hbase-protocol:jar:2.2.3 in the shaded jar.
[INFO] Including commons-codec:commons-codec:jar:1.10 in the shaded jar.
[INFO] Including org.apache.hbase.thirdparty:hbase-shaded-miscellaneous:jar:2.2.1 in the shaded jar.
[INFO] Including com.google.protobuf:protobuf-java:jar:2.5.0 in the shaded jar.
[INFO] Including org.apache.hbase.thirdparty:hbase-shaded-netty:jar:2.2.1 in the shaded jar.
[INFO] Including org.apache.zookeeper:zookeeper:jar:3.4.14 in the shaded jar.
[INFO] Including org.apache.htrace:htrace-core4:jar:4.2.0-incubating in the shaded jar.
[INFO] Including io.dropwizard.metrics:metrics-core:jar:3.2.6 in the shaded jar.
[INFO] Including org.apache.commons:commons-crypto:jar:1.0.0 in the shaded jar.

So netty-all is missing, as is commons-lang3.

Now netty I get; 2.2 uses hbase-shaded-netty (but then I'd like a dedicated commit removing an excess dependency; can be a hotfix 🤷).
But the commons-lang3 dependency does still seem to be there (but it's now being excluded for some reason).

[ferenc-csaky]

So netty-all is missing, as is commons-lang3.

Now netty I get; 2.2 uses hbase-shaded-netty (but then I'd like a dedicated commit removing an excess dependency; can be a hotfix 🤷). But the commons-lang3 dependency does still seem to be there (but it's now being excluded for some reason).

commons-lang3 got lost during the dependency convergence work, but now I added back both. I also made sure to use the same commons-codec version everywhere, cause that was also messed up. Now everything should be good.

[zentol]

Found another problem:
The 1.14 sql connector now bundles commons-logging which it didn't in 1.16.0.

[ferenc-csaky]

I compared the JAR files and all of them has the exact same content now, except the meta inf.

[zentol]

I compared the JAR files and all of them has the exact same content now, except the meta inf.

Apparently you missed #4 (review) though.

Hold on did I mix things up?...