[FLINK-31759][JDBC] Update some external connectors to use sql_connector_download_table and connector_artifact shortcode #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
reswqa
force-pushed
the
FLINK-31759-main
branch
from
dd09f79
to
ae62e3d
Compare
TanYuxin-tyx
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
@reswqa Thanks for fixing the doc version. LGTM
The test failed. But I found it's irrelevant and a jira about this has been opened.
|
Thanks @TanYuxin-tyx for the review, AZP failed is irrelevant. Merged. |
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr should also backports v3.0 branch.