[FLINK-32714] Add dialect for OceanBase database #72
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
whhe
force-pushed
the
oceanbase-dialect
branch
3 times, most recently
from
5b24a8f
to
ede507d
Compare
whhe
force-pushed
the
oceanbase-dialect
branch
3 times, most recently
from
f95b4a0
to
29a2307
Compare
whhe
force-pushed
the
oceanbase-dialect
branch
2 times, most recently
from
5c39fb2
to
d531bb0
Compare
|
I enabled the it cases for Mysql mode of OceanBase, and the ci generally passed. PTAL @leonardBang @MartijnVisser |
whhe
force-pushed
the
oceanbase-dialect
branch
from
d531bb0
to
4588188
Compare
|
@eskabetxe Do you want to take a look? |
.../java/org/apache/flink/connector/jdbc/databases/oceanbase/dialect/OceanBaseRowConverter.java
Outdated
Show resolved
Hide resolved
...connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialectFactory.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/flink/connector/jdbc/internal/options/InternalJdbcConnectionOptions.java
Outdated
Show resolved
Hide resolved
...connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcConnectorOptions.java
Outdated
Show resolved
Hide resolved
...g/apache/flink/connector/jdbc/databases/oceanbase/dialect/OceanBaseMysqlDialectTypeTest.java
Show resolved
Hide resolved
...che/flink/connector/jdbc/databases/oceanbase/table/OceanBaseMySqlDynamicTableSinkITCase.java
Show resolved
Hide resolved
...e/flink/connector/jdbc/databases/oceanbase/table/OceanBaseMySqlDynamicTableSourceITCase.java
Show resolved
Hide resolved
whhe
force-pushed
the
oceanbase-dialect
branch
from
a0ecdbc
to
cb7d1cf
Compare
whhe
force-pushed
the
oceanbase-dialect
branch
from
f86c45b
to
b26d144
Compare
|
I added test cases for OceanBase Oracle mode, but because there is no docker environment, they can only be executed locally. Below is the output of testing after I set the connection properties in |
|
Hello @MartijnVisser @davidradl Is it OK to keep the driver with 'provide' or 'test' scope here? If not, I may have to remove it and disable other IT cases in order to make the CI to pass. |
whhe
force-pushed
the
oceanbase-dialect
branch
2 times, most recently
from
dcb5f3d
to
f8281c6
Compare
My thinking is that the CI tests should always pass. It think it is ok to leave test code in the codebase that can be used for local tests - ideally with instructions, but they should not case the CI to fail. |
Yes. If we have an enforcer rule that checks if we're not bundling this driver, I think we're safe. |
whhe
force-pushed
the
oceanbase-dialect
branch
2 times, most recently
from
9467c6e
to
9fccfb1
Compare
whhe
force-pushed
the
oceanbase-dialect
branch
from
73d782c
to
0f897d1
Compare
|
@eskabetxe PTAL |
|
Hi @MartijnVisser @eskabetxe can we continue the review when you have time? |
|
Anyone available please take a look on this. |
|
Awesome work, congrats on your first merged pull request! |
Currently the jdbc url is used to determine the dialect, but OceanBase has two sql compatible modes as 'mysql' and 'oracle', so additional information is needed to determine the sql dialect. In this PR I add a parameter 'compatible-mode', which may break some APIs in the process of creating jdbc dialect.