Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35010][connectors/mongodb] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Mongodb connector #32

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

GOODBOY008
Copy link
Member

Changes:

  • Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.0 for Flink Mongodb connector

@GOODBOY008
Copy link
Member Author

@Jiabao-Sun PTAL

@Jiabao-Sun Jiabao-Sun self-requested a review April 6, 2024 12:46

<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GOODBOY008, why do we need the commons-codec dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GOODBOY008 that seems a mistake, see https://issues.apache.org/jira/browse/COMPRESS-659.
I think we should bump commons-compress version to 1.26.1.

…press from 1.24.0 to 1.26.1 for Flink Mongodb connector
@GOODBOY008
Copy link
Member Author

@Jiabao-Sun PR updated and version to 1.26.1.

Copy link
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GOODBOY008 for this contribution.
LGTM.

@Jiabao-Sun Jiabao-Sun changed the title [FLINK-35010][connectors/mongodb] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.0 for Flink Mongodb connector [FLINK-35010][connectors/mongodb] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Mongodb connector Apr 9, 2024
@Jiabao-Sun Jiabao-Sun merged commit ee1146d into apache:main Apr 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants