[FLINK-24302][Connector/Pulsar] Drop the use of direct buffer memory for supporting Java 11. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syhily
force-pushed
the
hotfix/java-11-compatible
branch
3 times, most recently
from
b8fb055
to
9f859fc
Compare
…ink. Re-enable all the tests for Java 11.
syhily
force-pushed
the
hotfix/java-11-compatible
branch
from
9f859fc
to
0766103
Compare
|
Is this still needed now that Pulsar 2.11 client is used ? |
Yep. The main issue isn't resolved after Pulsar has released the 3.0.0 |
|
@syhily is there an issue or related PRs in the Pulsar side to describe why we have to do these tricks in the connector side? |
Yep. Here it is. apache/pulsar#17989 |
|
Close this PR for in favor of the #55. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working in progress PR for testing if we have supported Java 11 by changing the Netty allocator type to heap instead of direct buffer memory.