Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31676][Connector/Pulsar] Replace Shaded Guava from Flink with Shaded Guava from Pulsar #37

Merged

Conversation

MartijnVisser
Copy link
Contributor

Purpose of the change

Brief change log

  • Removed all occurrences of org.apache.flink.shaded.guava30.com with org.apache.pulsar.shade.com

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Significant changes

(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for
convenience.)

  • Dependencies have been added or upgraded
  • Public API has been changed (Public API is any class annotated with @Public(Evolving))
  • Serializers have been changed
  • New feature has been introduced
    • If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)

@MartijnVisser MartijnVisser force-pushed the FLINK-31676-remove-shaded-guava branch from c3f779f to 3910dad Compare March 31, 2023 11:40
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a pom.xml change, how can we prevent dependencies on Flink Shade predictably?

@MartijnVisser
Copy link
Contributor Author

how can we prevent dependencies on Flink Shade predictably?

I don't think we can; it's a transitive dependency of Flink, which is needed in order to build/test the connector.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your explanation! Let's fix these occurrences then.

@MartijnVisser MartijnVisser merged commit 104bdc3 into apache:main Mar 31, 2023
2 checks passed
@MartijnVisser MartijnVisser deleted the FLINK-31676-remove-shaded-guava branch March 31, 2023 13:53
@syhily
Copy link
Contributor

syhily commented Apr 4, 2023

flink-shade is an transitive dependency. We can't prevent the use of it, but we can ask others to use Pulsar's shaded Guava when review the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants