Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-33815][Connector / Pulsar] Add tests against jdk17 for pulsar connector #71

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[FLINK-33815][Connector / Pulsar] Add tests against jdk17 for pulsar connector #71

merged 1 commit into from
Dec 13, 2023

Conversation

snuyanzin
Copy link
Contributor

@snuyanzin snuyanzin commented Dec 13, 2023 •
edited
Loading

Purpose of the change

1.18.x supports jdk 17, so it would make sense to add tests against java 17

Brief change log

gha

Verifying this change

This change is a trivial rework

Significant changes

  • Dependencies have been added or upgraded
  • Public API has been changed (Public API is any class annotated with @Public(Evolving))
  • Serializers have been changed
  • New feature has been introduced
    • If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)

@snuyanzin
Copy link
Contributor Author

@leonardBang @tisonkun could you please have a look?

leonardBang
leonardBang approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snuyanzin for the contribution, LGTM.

@leonardBang leonardBang merged commit 8bfbe33 into apache:main Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardBang leonardBang leonardBang approved these changes

@tisonkun tisonkun Awaiting requested review from tisonkun

Assignees

@snuyanzin snuyanzin

Labels
component=BuildSystem
Projects
None yet
Milestone
No milestone
2 participants
@snuyanzin @leonardBang