Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34267][CI] Update miniconda install script to fix build on MacOS #34

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

z3d1k
Copy link

@z3d1k z3d1k commented Jan 29, 2024

Fix miniconda environment install on MacOS.
Change has been tested on MacOS 14.2.1 and Amazon Linux 2.

Copy link

@ferenc-csaky ferenc-csaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, just bumped into this myself when externalizing the Cassandra Python connector.

Tested on Mac M1 OS 14.2.1, also worked for me!

@ferenc-csaky
Copy link

@dianfu can you pls. check on this if you have some time? Thanks!

Copy link

@gaborgsomogyi gaborgsomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gaborgsomogyi
Copy link

It would be good to change in Flink main repo too.

@z3d1k
Copy link
Author

z3d1k commented Feb 7, 2024

Thanks for the feedback @gaborgsomogyi, I see that main repo has newer miniconda versions in the script:
Miniconda3-py310_23.5.2-0-{OS} in main vs Miniconda3-4.7.12.1-{OS} here.
https://github.com/apache/flink/blame/master/flink-python/dev/lint-python.sh#L200-L203

I will verify that version in main repo works and update this PR to align versions.

@gaborgsomogyi
Copy link

I've just taken a small look at the release date of the mentioned version and seems like it's released on 2019-10-25. Is it possible to use a more recent version to catch up?

@gaborgsomogyi
Copy link

@pvary do you remember why we added the old conda version here?

@pvary
Copy link

pvary commented Feb 8, 2024

@pvary do you remember why we added the old conda version here?

IIRC the issue was to run the python tests on Mac with the new Python versions

@gaborgsomogyi
Copy link

@pvary Thanks! Now I remember that the newest conda version would work when the connector would bump Flink version. Merging...

@gaborgsomogyi gaborgsomogyi merged commit e6e1426 into apache:ci_utils Feb 9, 2024
14 checks passed
@gaborgsomogyi
Copy link

Thanks for the fix!

@z3d1k z3d1k deleted the FLINK-34267 branch February 9, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants