-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34267][CI] Update miniconda install script to fix build on MacOS #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks, just bumped into this myself when externalizing the Cassandra Python connector.
Tested on Mac M1 OS 14.2.1, also worked for me!
@dianfu can you pls. check on this if you have some time? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It would be good to change in Flink main repo too. |
Thanks for the feedback @gaborgsomogyi, I see that main repo has newer miniconda versions in the script: I will verify that version in main repo works and update this PR to align versions. |
I've just taken a small look at the release date of the mentioned version and seems like it's released on |
@pvary do you remember why we added the old conda version here? |
IIRC the issue was to run the python tests on Mac with the new Python versions |
@pvary Thanks! Now I remember that the newest conda version would work when the connector would bump Flink version. Merging... |
Thanks for the fix! |
Fix miniconda environment install on MacOS.
Change has been tested on MacOS 14.2.1 and Amazon Linux 2.