[FLINK-34282][docker] Updates snapshot workflow configuration #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingGe
reviewed
Feb 9, 2024
| - flink_version: 1.18-SNAPSHOT | ||
| branch: dev-1.18 | ||
| - flink_version: 1.17-SNAPSHOT | ||
| branch: dev-1.17 | ||
| - flink_version: 1.16-SNAPSHOT |
There was a problem hiding this comment.
You should mean that we only maintain images of the latest three versions. I couldn't find it in the https://github.com/apache/flink-docker/blob/master/README.md you mentioned in the PR description. Does it make sense to update the PR description to make the intention of the PR a little bit more clear?
There was a problem hiding this comment.
I updated the PR to include this minor README change in a hotfix PR 👍
There was a problem hiding this comment.
@JingGe can you merge the PR after approving it? I'm gonna be offline for the rest of the day. But it would be nice to have the snapshot Docker images being created over the weekend already.
….19 branch and new dev-master.
preparations - 1.15 and 1.16 are already deprecated - 1.17 is kept because we still might do a final patch release as part of the 1.19.0 release
XComp
force-pushed
the
FLINK-34282-master
branch
from
5c5a650
to
f2deea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we are aligned with what's described in the README.md again.