[FLINK-16260] Add release.metadata files + Java 11 release for 1.11.1 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmetzger
commented
Jul 30, 2020
| @@ -47,7 +47,7 @@ pruneTags() { | |||
| else | |||
| # remove "latest" and any "scala_" tag, unless it is the latest version | |||
| # the "scala_" tag has a similar semantic as the "latest" tag in docker registries. | |||
| echo $tags | sed -E 's|, (scala\|latest)[-_[:alnum:]]*||g' | |||
| echo $tags | sed -E 's|, (scala\|latest)[-_.[:alnum:]]*||g' | |||
There was a problem hiding this comment.
Otherwise, the tags look like this Tags: 1.10.1-scala_2.11, 1.10-scala_2.11.11
|
Thanks for the review ... merging. I'll then proceed with a PR towards the official docker repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.