Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 1.12: Add GPG and update testing script for 1.12.2 #67

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

rkhachatryan
Copy link
Contributor

No description provided.

@rkhachatryan rkhachatryan marked this pull request as ready for review March 3, 2021 15:18
@rmetzger
Copy link
Contributor

rmetzger commented Mar 4, 2021

I manually restarted the travis build

@rmetzger
Copy link
Contributor

rmetzger commented Mar 4, 2021

It seems there's something wrong with the wget -nv -O flink.tgz https://www.apache.org/dyn/closer.cgi?action=download&filename=flink/flink-1.12.2/flink-1.12.2-bin-scala_2.11.tgz command. Also locally, I'm facing issues with the wget call (downloading from the browser works).

@rkhachatryan
Copy link
Contributor Author

You are right. Quotes are missing in url.

@rmetzger
Copy link
Contributor

rmetzger commented Mar 4, 2021

Why is this error surfacing now? The Dockerfile hasn't been updated? https://github.com/apache/flink-docker/blame/dev-master/Dockerfile-debian.template#L61

@rkhachatryan
Copy link
Contributor Author

I don't see any changes in the scripts generating URLs too at least since Jul 2020.
Probably the base image changed?

I opened a PR to check if quoting fixes the problem: #70

@zentol
Copy link
Contributor

zentol commented Mar 4, 2021

Given that other builds are currently passing without the added quotes I'd think that this is just mirrors causing problems.

@rmetzger
Copy link
Contributor

rmetzger commented Mar 4, 2021

Maybe the 1.12.2 release hasn't been synched to all mirrors yet?
Shall we use archive.apache.org 🙄 ?

@zentol
Copy link
Contributor

zentol commented Mar 4, 2021

the weird thing is that if the mirrors weren't synced wget would just fail and not stall. It looks more like we're hitting an exceptionally slow mirro :/

@rmetzger
Copy link
Contributor

rmetzger commented Mar 4, 2021

@rkhachatryan maybe push a version to travis where wget is verbosely logging what's going on?

@zentol
Copy link
Contributor

zentol commented Mar 4, 2021

Shall we use archive.apache.org

Given the issues that we're struggling with in the Flink repo I don't think this is a viable option.

@zentol
Copy link
Contributor

zentol commented Mar 4, 2021

Issue seems to be resolved.

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1; please remember to revert the wget change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants