Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-27261] Disable web.cancel.enable for session cluster #198

Merged
merged 3 commits into from May 11, 2022

Conversation

SteNicholas
Copy link
Member

In FLINK-27154, we disable web.cancel.enable for application cluster. We should also do this for session cluster.

The brief change log

  • Sets web.cancel.enable to false at default in FlinkConfigBuilder to avoid users accidentally cancelling jobs.

@SteNicholas SteNicholas changed the title [FLINK-27261] Disable web.cancel.enable for session cluster [FLINK-27261] Disable web.cancel.enable for session cluster May 9, 2022
@gyfora
Copy link
Contributor

gyfora commented May 10, 2022

Could we also disable web submission as part of this PR? I think that would be nice :)

@SteNicholas SteNicholas force-pushed the FLINK-27261 branch 3 times, most recently from 3b5d769 to c78a0b0 Compare May 11, 2022 05:05
@SteNicholas
Copy link
Member Author

@gyfora, the behaviour that the web submission disables will cause the failure for the uploading and running the job. Hence I don't disable web submission in this PR.

@gyfora
Copy link
Contributor

gyfora commented May 11, 2022

Ok, thanks for checking :)

Copy link
Contributor

@gyfora gyfora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@wangyang0918 wangyang0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for merging.

@wangyang0918 wangyang0918 merged commit 60654f4 into apache:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants