Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-27595] Helm - made security context configurable #210

Merged
merged 2 commits into from May 13, 2022
Merged

[FLINK-27595] Helm - made security context configurable #210

merged 2 commits into from May 13, 2022

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented May 12, 2022

No description provided.

@haoxins haoxins changed the title Helm - made securityContext configurable [FLINK-27595] Helm - made securityContext configurable May 12, 2022
@haoxins haoxins changed the title [FLINK-27595] Helm - made securityContext configurable [FLINK-27595] Helm - made security context configurable May 12, 2022
@mbalassi mbalassi self-requested a review May 12, 2022 17:01
mbalassi
mbalassi approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@mbalassi mbalassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@morhidi
Copy link
Contributor

morhidi commented May 12, 2022

LGTM too. It maybe worth defining separate securityContext at container level (webhook/operator) too with an empty body {}.

@haoxins
Copy link
Contributor Author

haoxins commented May 12, 2022

LGTM too. It maybe worth defining separate securityContext at container level (webhook/operator) too with an empty body {}.

added

@morhidi
Copy link
Contributor

morhidi commented May 12, 2022

thanks, +1 for merging

wangyang0918
wangyang0918 approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@wangyang0918 wangyang0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

Merging now

@wangyang0918 wangyang0918 merged commit af08660 into apache:main May 13, 2022
@haoxins haoxins deleted the helm-extract-sec-to-values branch May 13, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbalassi mbalassi mbalassi approved these changes

@wangyang0918 wangyang0918 wangyang0918 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@haoxins @morhidi @mbalassi @wangyang0918