Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-27665] Optimize event triggering on DeploymentFailedExceptions #220

Merged
merged 1 commit into from May 18, 2022
Merged

[FLINK-27665] Optimize event triggering on DeploymentFailedExceptions #220

merged 1 commit into from May 18, 2022

Conversation

morhidi
Copy link
Contributor

@morhidi morhidi commented May 17, 2022

  • Separated the event related logic from the DeploymentFailedExceptions
  • Introduced a new component type for JobManagerDeployment, reporting DeploymentFailedExceptions
  • Reduced the event types to Warning and Normal only see API docs

@morhidi
Copy link
Contributor Author

morhidi commented May 17, 2022

cc @wangyang0918 @Aitozi

Aitozi
Aitozi approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@Aitozi Aitozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyfora gyfora merged commit e847662 into apache:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aitozi Aitozi Aitozi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@morhidi @Aitozi @gyfora